0001318: Not all notes show their references

(0003592)
bmcage (administrator)
2007-10-22 12:05

ok, this is a serious bug.

Probably on delete of the note on note view, the reference in the event attribute is also left hanging, causing broken links.
Can you test this?

(0003593)
bmcage (administrator)
2007-10-22 12:06

putting priority on High, 3.0 cannot be released with this bug in it

(0003594)
pioterus (reporter)
2007-10-22 12:31

Yes, after deleting a note on note view, reference is broken. I get the message about necessity of running the Check and repair tool with the error: 'NoneType' object has no attribute 'get'

(0003911)
bmcage (administrator)
2007-12-10 14:57

OK, the original bug is solved, and was also present in 2.2.x as there the attribute source was not in reference list of the sources.

However, on delete of the note, the attribute notelist is still not updated, you obtain now the error:

Traceback (most recent call last):
  File "/home/cristina/Benny/programs/gramps/gramps23/src/DisplayTabs/_EmbeddedList.py", line 408, in rebuild
    self.model = self.build_model(self.get_data(), self.dbstate.db)
  File "/home/cristina/Benny/programs/gramps/gramps23/src/DisplayTabs/_NoteModel.py", line 42, in __init__
    text = note.get().replace('\n', ' ')
AttributeError: 'NoneType' object has no attribute 'get'

This means that the delete object function in dbdir does not contain code to delete the note in the attribute.

(0003912)
bmcage (administrator)
2007-12-10 14:58

pioterus,

something else, I do not see the problem with the address. I see object with address in the note reference list.
Can you test this and confirm if I'm right ?

(0003913)
bmcage (administrator)
2007-12-10 15:14

This is serious, deletion is wrongly implemented.

Delete of note only deletes primary objects notes, not secondary object notes.
This has to be designed differently

(0003914)
bmcage (administrator)
2007-12-10 15:49

Note to myself, all NoteBase must implement remove_note and a new get_note_child_list method return secondary child objects which are also NoteBase.

Then remove_note must do remove and then call remove_note on all objects returned by get_note_child_list.

Then try to warp the mind if no recursion can happen....notes are more present than sources, eg person -> attribute -> sourceref -> note
I think it will be ok...

(0003936)
bmcage (administrator)
2007-12-14 16:56

svn up. SHould be fixed. Needs some more testing though perhaps.

Issue History
Date Modified	Username	Field	Change
2007-10-22 08:46	pioterus	New Issue
2007-10-22 12:05	bmcage	Note Added: 0003592
2007-10-22 12:06	bmcage	Note Added: 0003593
2007-10-22 12:06	bmcage	Priority	normal => high
2007-10-22 12:31	pioterus	Note Added: 0003594
2007-12-10 14:57	bmcage	Note Added: 0003911
2007-12-10 14:58	bmcage	Note Added: 0003912
2007-12-10 15:14	bmcage	Note Added: 0003913
2007-12-10 15:46	bmcage	Status	new => assigned
2007-12-10 15:46	bmcage	Assigned To	=> bmcage
2007-12-10 15:49	bmcage	Note Added: 0003914
2007-12-14 16:56	bmcage	Status	assigned => resolved
2007-12-14 16:56	bmcage	Resolution	open => fixed
2007-12-14 16:56	bmcage	Note Added: 0003936

Notes
(0003592) bmcage (administrator) 2007-10-22 12:05	ok, this is a serious bug. Probably on delete of the note on note view, the reference in the event attribute is also left hanging, causing broken links. Can you test this?

(0003593) bmcage (administrator) 2007-10-22 12:06	putting priority on High, 3.0 cannot be released with this bug in it

(0003594) pioterus (reporter) 2007-10-22 12:31	Yes, after deleting a note on note view, reference is broken. I get the message about necessity of running the Check and repair tool with the error: 'NoneType' object has no attribute 'get'

(0003911) bmcage (administrator) 2007-12-10 14:57	OK, the original bug is solved, and was also present in 2.2.x as there the attribute source was not in reference list of the sources. However, on delete of the note, the attribute notelist is still not updated, you obtain now the error: Traceback (most recent call last): File "/home/cristina/Benny/programs/gramps/gramps23/src/DisplayTabs/_EmbeddedList.py", line 408, in rebuild self.model = self.build_model(self.get_data(), self.dbstate.db) File "/home/cristina/Benny/programs/gramps/gramps23/src/DisplayTabs/_NoteModel.py", line 42, in __init__ text = note.get().replace('\n', ' ') AttributeError: 'NoneType' object has no attribute 'get' This means that the delete object function in dbdir does not contain code to delete the note in the attribute.

(0003912) bmcage (administrator) 2007-12-10 14:58	pioterus, something else, I do not see the problem with the address. I see object with address in the note reference list. Can you test this and confirm if I'm right ?

(0003913) bmcage (administrator) 2007-12-10 15:14	This is serious, deletion is wrongly implemented. Delete of note only deletes primary objects notes, not secondary object notes. This has to be designed differently

(0003914) bmcage (administrator) 2007-12-10 15:49	Note to myself, all NoteBase must implement remove_note and a new get_note_child_list method return secondary child objects which are also NoteBase. Then remove_note must do remove and then call remove_note on all objects returned by get_note_child_list. Then try to warp the mind if no recursion can happen....notes are more present than sources, eg person -> attribute -> sourceref -> note I think it will be ok...

(0003936) bmcage (administrator) 2007-12-14 16:56	svn up. SHould be fixed. Needs some more testing though perhaps.

Relationships