|Anonymous | Login | Signup for a new account||2013-06-18 17:27 MST|
|Main | My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001318||Gramps 3.0.X||Other||public||2007-10-22 08:46||2007-12-14 16:56|
|Target Version||Fixed in Version|
|Summary||0001318: Not all notes show their references|
|Description||Notes added to event attributes do not list their references. The same applies to address notes.|
|Steps To Reproduce||- open Event editor|
- add a new attribute
- add a note to the attribute
-> References tab remains empty, notes with reference count=0 also retrurns this note, although it's present on that attribute
- add a new address to a person or antother object that allows it
- add a note to that address
-> the note shows no references
|Tags||No tags attached.|
ok, this is a serious bug.
Probably on delete of the note on note view, the reference in the event attribute is also left hanging, causing broken links.
Can you test this?
|putting priority on High, 3.0 cannot be released with this bug in it|
|Yes, after deleting a note on note view, reference is broken. I get the message about necessity of running the Check and repair tool with the error: 'NoneType' object has no attribute 'get'|
OK, the original bug is solved, and was also present in 2.2.x as there the attribute source was not in reference list of the sources.
However, on delete of the note, the attribute notelist is still not updated, you obtain now the error:
Traceback (most recent call last):
File "/home/cristina/Benny/programs/gramps/gramps23/src/DisplayTabs/_EmbeddedList.py", line 408, in rebuild
self.model = self.build_model(self.get_data(), self.dbstate.db)
File "/home/cristina/Benny/programs/gramps/gramps23/src/DisplayTabs/_NoteModel.py", line 42, in __init__
text = note.get().replace('\n', ' ')
AttributeError: 'NoneType' object has no attribute 'get'
This means that the delete object function in dbdir does not contain code to delete the note in the attribute.
something else, I do not see the problem with the address. I see object with address in the note reference list.
Can you test this and confirm if I'm right ?
This is serious, deletion is wrongly implemented.
Delete of note only deletes primary objects notes, not secondary object notes.
This has to be designed differently
Note to myself, all NoteBase must implement remove_note and a new get_note_child_list method return secondary child objects which are also NoteBase.
Then remove_note must do remove and then call remove_note on all objects returned by get_note_child_list.
Then try to warp the mind if no recursion can happen....notes are more present than sources, eg person -> attribute -> sourceref -> note
I think it will be ok...
|svn up. SHould be fixed. Needs some more testing though perhaps.|
|2007-10-22 08:46||pioterus||New Issue|
|2007-10-22 12:05||bmcage||Note Added: 0003592|
|2007-10-22 12:06||bmcage||Note Added: 0003593|
|2007-10-22 12:06||bmcage||Priority||normal => high|
|2007-10-22 12:31||pioterus||Note Added: 0003594|
|2007-12-10 14:57||bmcage||Note Added: 0003911|
|2007-12-10 14:58||bmcage||Note Added: 0003912|
|2007-12-10 15:14||bmcage||Note Added: 0003913|
|2007-12-10 15:46||bmcage||Status||new => assigned|
|2007-12-10 15:46||bmcage||Assigned To||=> bmcage|
|2007-12-10 15:49||bmcage||Note Added: 0003914|
|2007-12-14 16:56||bmcage||Status||assigned => resolved|
|2007-12-14 16:56||bmcage||Resolution||open => fixed|
|2007-12-14 16:56||bmcage||Note Added: 0003936|
|MantisBT 1.2.14 [^] Copyright © 2000 - 2013 MantisBT Team|